Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new IBM GPFS (ibmgpfs) Cinder storage backend implementation to Sunbeam, plus unit tests and common test fixture updates so the backend participates in the shared backend test suite.
Changes:
- Introduces
IbmgpfsBackendandIbmgpfsConfig(Pydantic config model) for the new backend. - Adds a dedicated unit test module for ibmgpfs and updates shared backend tests to include it.
- Extends pytest fixtures to provide the new backend instance and include it in parametrized runs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sunbeam-python/sunbeam/storage/backends/ibmgpfs/backend.py | New GPFS backend + config model definition. |
| sunbeam-python/sunbeam/storage/backends/ibmgpfs/init.py | Package init for the new backend module. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_ibmgpfs.py | New unit tests for ibmgpfs backend and config validation. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py | Adds ibmgpfs to shared uniqueness/expectation tests. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py | Adds ibmgpfs_backend fixture + includes it in any_backend. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahmad-can
force-pushed
the
feature/generate-ibmgpfs-charm
branch
from
621d216 to
de3e66f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/983829